Skip to content

e2e: fix typos and minor grammar issues #1271

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 14, 2022
Merged

e2e: fix typos and minor grammar issues #1271

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion test/e2e/dlb/dlb.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@ func describe() {
}

for _, resource := range []v1.ResourceName{"dlb.intel.com/pf", "dlb.intel.com/vf"} {
ginkgo.By("checking the " + resource.String() + " resource is allocatable")
ginkgo.By("checking if the " + resource.String() + " resource is allocatable")
if err = utils.WaitForNodesWithResource(f.ClientSet, resource, 30*time.Second); err != nil {
framework.Failf("unable to wait for nodes to have positive allocatable resource %s: %v", resource, err)
}
Expand Down
2 changes: 1 addition & 1 deletion test/e2e/dsa/dsa.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@ func describe() {
framework.Failf("container filesystem info checks failed: %v", err)
}

ginkgo.By("checking the resource is allocatable")
ginkgo.By("checking if the resource is allocatable")
if err = utils.WaitForNodesWithResource(f.ClientSet, "dsa.intel.com/wq-user-dedicated", 300*time.Second); err != nil {
framework.Failf("unable to wait for nodes to have positive allocatable resource: %v", err)
}
Expand Down
4 changes: 2 additions & 2 deletions test/e2e/gpu/gpu.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ func describe() {
framework.Failf("container filesystem info checks failed: %v", err)
}

ginkgo.By("checking the resource is allocatable")
ginkgo.By("checking if the resource is allocatable")
if err = utils.WaitForNodesWithResource(f.ClientSet, "gpu.intel.com/i915", 30*time.Second); err != nil {
framework.Failf("unable to wait for nodes to have positive allocatable resource: %v", err)
}
Expand All @@ -97,7 +97,7 @@ func describe() {
pod, err := f.ClientSet.CoreV1().Pods(f.Namespace.Name).Create(context.TODO(), podSpec, metav1.CreateOptions{})
framework.ExpectNoError(err, "pod Create API error")

ginkgo.By("waiting the pod to finnish successfully")
ginkgo.By("waiting the pod to finish successfully")
e2epod.NewPodClient(f).WaitForSuccess(pod.ObjectMeta.Name, 60*time.Second)

ginkgo.By("checking log output")
Expand Down
2 changes: 1 addition & 1 deletion test/e2e/iaa/iaa.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@ func describe() {
framework.Failf("container filesystem info checks failed: %v", err)
}

ginkgo.By("checking the resource is allocatable")
ginkgo.By("checking if the resource is allocatable")
if err = utils.WaitForNodesWithResource(f.ClientSet, "iaa.intel.com/wq-user-dedicated", 300*time.Second); err != nil {
framework.Failf("unable to wait for nodes to have positive allocatable resource: %v", err)
}
Expand Down
6 changes: 3 additions & 3 deletions test/e2e/qat/qatplugin_dpdk.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,21 +75,21 @@ func describeQatDpdkPlugin() {
framework.Failf("container filesystem info checks failed: %v", err)
}

ginkgo.By("checking the resource is allocatable")
ginkgo.By("checking if the resource is allocatable")
if err := utils.WaitForNodesWithResource(f.ClientSet, "qat.intel.com/generic", 30*time.Second); err != nil {
framework.Failf("unable to wait for nodes to have positive allocatable resource: %v", err)
}

ginkgo.By("submitting a crypto pod requesting QAT resources")
e2ekubectl.RunKubectlOrDie(f.Namespace.Name, "apply", "-k", filepath.Dir(cryptoTestYamlPath))

ginkgo.By("waiting the crypto pod to finnish successfully")
ginkgo.By("waiting the crypto pod to finish successfully")
e2epod.NewPodClient(f).WaitForSuccess("qat-dpdk-test-crypto-perf-tc1", 60*time.Second)

ginkgo.By("submitting a compress pod requesting QAT resources")
e2ekubectl.RunKubectlOrDie(f.Namespace.Name, "apply", "-k", filepath.Dir(compressTestYamlPath))

ginkgo.By("waiting the compress pod to finnish successfully")
ginkgo.By("waiting the compress pod to finish successfully")
e2epod.NewPodClient(f).WaitForSuccess("qat-dpdk-test-compress-perf-tc1", 60*time.Second)
})
}
4 changes: 2 additions & 2 deletions test/e2e/qat/qatplugin_kernel.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ func describeQatKernelPlugin() {
framework.Failf("container filesystem info checks failed: %v", err)
}

ginkgo.By("checking the resource is allocatable")
ginkgo.By("checking if the resource is allocatable")
if err = utils.WaitForNodesWithResource(f.ClientSet, "qat.intel.com/cy1_dc0", 30*time.Second); err != nil {
framework.Failf("unable to wait for nodes to have positive allocatable resource: %v", err)
}
Expand Down Expand Up @@ -95,7 +95,7 @@ func describeQatKernelPlugin() {
podSpec, metav1.CreateOptions{})
framework.ExpectNoError(err, "pod Create API error")

ginkgo.By("waiting the pod to finnish successfully")
ginkgo.By("waiting the pod to finish successfully")
e2epod.NewPodClient(f).WaitForFinish(pod.ObjectMeta.Name, 60*time.Second)
})
}
2 changes: 1 addition & 1 deletion test/e2e/qat/qatplugin_qatgen4_crypto.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ func describeQatPluginCy() {
framework.Failf("container filesystem info checks failed: %v", err)
}

ginkgo.By("checking the resource is allocatable")
ginkgo.By("checking if the resource is allocatable")
if err := utils.WaitForNodesWithResource(f.ClientSet, "qat.intel.com/cy", 30*time.Second); err != nil {
framework.Failf("unable to wait for nodes to have positive allocatable resource: %v", err)
}
Expand Down
4 changes: 2 additions & 2 deletions test/e2e/sgx/sgx.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@ func describe() {
framework.Failf("container filesystem info checks failed: %v", err)
}

ginkgo.By("checking the resource is allocatable")
ginkgo.By("checking if the resource is allocatable")
if err = utils.WaitForNodesWithResource(f.ClientSet, "sgx.intel.com/epc", 150*time.Second); err != nil {
framework.Failf("unable to wait for nodes to have positive allocatable epc resource: %v", err)
}
Expand Down Expand Up @@ -110,7 +110,7 @@ func describe() {
pod, err := f.ClientSet.CoreV1().Pods(f.Namespace.Name).Create(context.TODO(), podSpec, metav1.CreateOptions{})
framework.ExpectNoError(err, "pod Create API error")

ginkgo.By("waiting the pod to finnish successfully")
ginkgo.By("waiting the pod to finish successfully")
e2epod.NewPodClient(f).WaitForSuccess(pod.ObjectMeta.Name, 60*time.Second)
})
}