Launcher: fix iomp5, add transparent hugepage and add debug option #143
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ashokei
changed the title
Contributor
|
@liangan1 May I know if there is any UT that can cover the launcher? |
liangan1
reviewed
Dec 17, 2020
Contributor
liangan1
left a comment
liangan1
left a comment
There was a problem hiding this comment.
There is no UT to cover the launcher.
| if not arg: return | ||
| if os.path.exists(THP_LOC): | ||
| os.system("sync;echo 3 > /proc/sys/vm/drop_caches") | ||
| os.system(f"echo {arg} > {THP_LOC}") |
Contributor
There was a problem hiding this comment.
is it general to all Linux platform about the setting for transparent hugepage ?
Contributor
Author
There was a problem hiding this comment.
this is a kernel feature, so it usually common for all linux distros.
@liangan1 We'd better add UT to cover the basic functionalities. |
Contributor
|
@jgong5 ok |
EikanWang
pushed a commit
that referenced
this pull request
Oct 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.