This repository was archived by the owner on Aug 5, 2022. It is now read-only.
beignet: add ncurses dependency. #121
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
This is part of #109 already. |
Contributor
Author
|
@rojkov : Ah, ok. I'm fine with merging either PR... |
Contributor
Author
|
retest this please |
Contributor
This prevents "ld: cannot find -ltinfo" error when building beignet. The required ncurses library was accidentally brought to sysroot by Python2. If Python2 is removed or compiled so that it no longer depends on ncurses, ncurses is no longer in sysroot and beignet linking fails. Signed-off-by: Ismo Puustinen <ismo.puustinen@intel.com>
Contributor
Author
|
@mythi : I edited the commit message. Nevertheless, having beignet recipe not list all its dependencies is a bug. The Python change just exposed it. |
Contributor
|
@ipuustin yes, totally agree. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This prevents
ld: cannot find -ltinfoerror when building beignet.