This repository was archived by the owner on Aug 5, 2022. It is now read-only.
Reduce Python 3 dependencies #92
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
@ipuustin I think this is OK but perhaps follow-up with Ross if it was simply forgotten. |
mythi
reviewed
Mar 28, 2017
| PACKAGECONFIG_remove_pn-pulseaudio = "avahi" | ||
|
|
||
| # leave out readline, gdbm, and db | ||
| PACKAGECONFIG_pn-python3 = "" |
Contributor
Author
|
@rossburton: what's your take on this? Should we have this in refkit or could we add the functionality to oe-core? |
|
Sorry, slipped through. Yes, I think the PACKAGECONFIGs should be in core. It's very late but I'll review that properly and see what we can do. |
The three libraries' (readline, gdbm, and db) licenses belong to the GPLv3 family. Add them to to PACKAGECONFIG so they can be switched off if the licensing doesn't allow using them. Python build system autodetects the dependencies but doesn't allow them to be explicitly disabled, so just deal with the dependencies. The defaults in PACKAGECONFIG are the same as before, so there should be no change to current users. Signed-off-by: Ismo Puustinen <ismo.puustinen@intel.com>
Signed-off-by: Ismo Puustinen <ismo.puustinen@intel.com>
Contributor
|
This is on it's way to oe-core but let's take the bbappend in until then. |
Contributor
Author
|
It seems that this is somewhat broken now due to openembedded/openembedded-core@54a2549 . Need to investigate a bit. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Compile Python 3 without readline, gdbm, and db support. This removes the need for GPLv3 depedencies.
The patch was submitted upstream (https://patchwork.openembedded.org/patch/136368/) but never merged. This is the
.bbappendversion of it.