Skip to content

Conversation

@bnjbvr
Copy link
Contributor

@bnjbvr bnjbvr commented Apr 13, 2022

@bnjbvr
Copy link
Contributor Author

bnjbvr commented Apr 13, 2022

Nice! It now shows the same mingw failure that we were seeing on wasmtime, with @abrown's patches from #56.

Would be nice if someone wanted to fix this upstream, please :)

@abrown abrown changed the title Use the bash shell by default in CI ci: add MinGW build for Rust crate May 13, 2022
@abrown
Copy link
Contributor

abrown commented May 13, 2022

Summary of this investigation for later reference: in bytecodealliance/wasmtime#4003 we discovered that the ittapi C code uses the uncommon strnlen_s function. On older versions of MinGW (GitHub runners currently come with v8.1.0 pre-installed), this function was not available. Since v8.1.0, other versions have been published; this re-installs MinGW with a recent version which includes strnlen_s. The special upgrade code in the GitHub workflow can be removed if/when MinGW is upgraded in all Windows GitHub runners: actions/runner-images#5530. This issue only really applies if someone builds the ittapi crate with --target x86_64-pc-windows-gnu, the MinGW target.

@abrown abrown merged commit 26b3a81 into intel:master May 13, 2022
@bnjbvr bnjbvr deleted the patch-1 branch May 14, 2022 08:49
@bnjbvr
Copy link
Contributor Author

bnjbvr commented May 14, 2022

Thanks for pushing this through, @abrown!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants