Bug Fix - Dependency Confusion in oneccl_bind_pt package
#92
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liu-shaojun
changed the title
oneccl_bind_pt packageoneccl_bind_pt package
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR addresses BUG - Dependency Confusion in
oneccl_bind_ptpackage (see AO8-417).The issue arises because we currently use
--extra-index-urlin multiple places together with theoneccl_bind_ptdependency. Sinceoneccl_bind_ptis not published on pypi.org,pipwill first attempt to fetch from PyPI, and if a malicious actor publishes a fakeoneccl_bind_ptpackage there, our scripts would install it.Fix:
--extra-index-urlwith--index-url.piponly pulls from the trusted internal index and does not fallback topypi.org.