[ESIMD]Test correctness of type conversion fix #1170
Conversation
|
/verify with intel/llvm#6627 |
v-klochkov
left a comment
v-klochkov
left a comment
There was a problem hiding this comment.
Looks good to me. I have only few non-blocking comments.
| { | ||
| sycl::range<1> range(1); | ||
| sycl::buffer<double, 1> buffer_in(&input, range); | ||
| sycl::buffer<unsigned int, 1> buffer_out(&output, range); |
There was a problem hiding this comment.
Not a requirement: as soon as the test is 'double_conversion', it may be nice to test 'signed int' as well.
There was a problem hiding this comment.
Added some tests for basic test fir signed int
|
/verify with intel/llvm#6627 |
|
@fineg74 - please fix one more clang-format issue |
|
The test fails with error: LLVM ERROR: GenX execution width and GRF crossing legalization failed for: < %1 = fptoui <1 x double> %call2.i.i.i.i.esimd.i.i to <1 x i32>>: 'double' data type is not supported by this target |
v-klochkov
left a comment
v-klochkov
left a comment
There was a problem hiding this comment.
Please add 'aspect-fp64' to 'REQUIRES' section.
|
@v-klochkov could you please merge the test |
* Test correctness of type conversion fix * Add requirement of aspect-fp64 for the test
…#1170) * Test correctness of type conversion fix * Add requirement of aspect-fp64 for the test
2 participants
Complementary compiler PR: intel/llvm#6627