This repository was archived by the owner on Mar 28, 2023. It is now read-only.
[SYCL] Remove UB in sampler.cpp #1177
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The SYCL 2020 specification states that the instance of a moved SYCL object is invalid, so any operations after a move exhibit undefined behaviour. sampler.cpp moves a sampler before hashing the moved object. In that case, the hasher will extract a nullptr implementation, which with intel/llvm#6598 will fail an assertion. Since this is UB, failing the assertion is valid and the UB case should be removed. This commit removes the UB operation and removes the unnecessary opencl_icd requirement in sampler.cpp. Signed-off-by: Larsen, Steffen <steffen.larsen@intel.com>
romanovvlad
approved these changes
Aug 24, 2022
myler
pushed a commit
to myler/llvm-test-suite
that referenced
this pull request
Mar 22, 2023
The SYCL 2020 specification states that the instance of a moved SYCL object is invalid, so any operations after a move exhibit undefined behaviour. sampler.cpp moves a sampler before hashing the moved object. In that case, the hasher will extract a nullptr implementation, which with intel/llvm#6598 will fail an assertion. Since this is UB, failing the assertion is valid and the UB case should be removed. This commit removes the UB operation and removes the unnecessary opencl_icd requirement in sampler.cpp. Signed-off-by: Larsen, Steffen <steffen.larsen@intel.com>
aelovikov-intel
pushed a commit
to aelovikov-intel/llvm
that referenced
this pull request
Mar 27, 2023
The SYCL 2020 specification states that the instance of a moved SYCL object is invalid, so any operations after a move exhibit undefined behaviour. sampler.cpp moves a sampler before hashing the moved object. In that case, the hasher will extract a nullptr implementation, which with intel#6598 will fail an assertion. Since this is UB, failing the assertion is valid and the UB case should be removed. This commit removes the UB operation and removes the unnecessary opencl_icd requirement in sampler.cpp. Signed-off-by: Larsen, Steffen <steffen.larsen@intel.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The SYCL 2020 specification states that the instance of a moved SYCL object is invalid, so any operations after a move exhibit undefined behaviour. sampler.cpp moves a sampler before hashing the moved object. In that case, the hasher will extract a nullptr implementation, which with intel/llvm#6598 will fail an assertion.
Since this is UB, failing the assertion is valid and the UB case should be removed.
This commit removes the UB operation and removes the unnecessary opencl_icd requirement in sampler.cpp.