Skip to content
This repository was archived by the owner on Mar 28, 2023. It is now read-only.

Conversation

@sarnex
Copy link

@sarnex sarnex commented Mar 23, 2023

This is based on #1033 which was never merged.

I don't think we have PVC machines in CI here, but I manually tested this on PVC and it passed.

This is based on intel#1033 which was never merged.

Signed-off-by: Sarnie, Nick <nick.sarnie@intel.com>
@sarnex sarnex marked this pull request as ready for review March 23, 2023 18:46
@sarnex sarnex requested a review from a team as a code owner March 23, 2023 18:46
Copy link

@v-klochkov v-klochkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I have few minor comments - all related to suffix 'cl' that is better not be used.

sarnex and others added 5 commits March 24, 2023 09:15
Co-authored-by: Vyacheslav Klochkov <vyacheslav.n.klochkov@intel.com>
Co-authored-by: Vyacheslav Klochkov <vyacheslav.n.klochkov@intel.com>
Co-authored-by: Vyacheslav Klochkov <vyacheslav.n.klochkov@intel.com>
Co-authored-by: Vyacheslav Klochkov <vyacheslav.n.klochkov@intel.com>
Co-authored-by: Vyacheslav Klochkov <vyacheslav.n.klochkov@intel.com>
@sarnex
Copy link
Author

sarnex commented Mar 24, 2023

Looks good. I have few minor comments - all related to suffix 'cl' that is better not be used.

Thanks, all fixed

Signed-off-by: Sarnie, Nick <nick.sarnie@intel.com>
@againull againull merged commit a88c066 into intel:intel Mar 24, 2023
aelovikov-intel pushed a commit to aelovikov-intel/llvm that referenced this pull request Mar 27, 2023
Signed-off-by: Sarnie, Nick <nick.sarnie@intel.com>
Co-authored-by: Vyacheslav Klochkov <vyacheslav.n.klochkov@intel.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants