Skip to content

[SYCL] Don't load all fallback spirv when launching from SPIRV file #11734

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 2, 2023
Merged

[SYCL] Don't load all fallback spirv when launching from SPIRV file #11734

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions sycl/source/detail/program_manager/program_manager.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1522,16 +1522,13 @@ void ProgramManager::flushSpecConstants(const program_impl &Prg,
Prg.flush_spec_constants(*Img, NativePrg);
}

// If the kernel is loaded from spv file, it may not include DeviceLib require
// mask, sycl runtime won't know which fallback device libraries are needed. In
// such case, the safest way is to load all fallback device libraries.
uint32_t ProgramManager::getDeviceLibReqMask(const RTDeviceBinaryImage &Img) {
const RTDeviceBinaryImage::PropertyRange &DLMRange =
Img.getDeviceLibReqMask();
if (DLMRange.isAvailable())
return DeviceBinaryProperty(*(DLMRange.begin())).asUint32();
else
return 0xFFFFFFFF;
return 0x0;
}

const KernelArgMask *
Expand Down