Skip to content

[SYCL] Fix mismatch between sub_group headers #1215

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 29, 2020
Merged

[SYCL] Fix mismatch between sub_group headers #1215

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
01336a7
[SYCL] Fix mismatch between sub_group headers
Pennycook Feb 28, 2020
57eb5ff
Run clang-format
Pennycook Feb 28, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion sycl/include/CL/sycl/intel/sub_group_host.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,7 +136,7 @@ struct sub_group {
}

template <typename T, access::address_space Space>
void store(multi_ptr<T, Space> dst, T &x) const {
void store(multi_ptr<T, Space> dst, const T &x) const {
throw runtime_error("Subgroups are not supported on host device. ");
}

Expand Down
16 changes: 16 additions & 0 deletions sycl/test/regression/sub-group-store-const-ref.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
// RUN: %clangxx -I %sycl_include -fsyntax-only -Xclang -verify %s
// expected-no-diagnostics
//
//==-- sub-group-store-const-ref.cpp ---------------------------------------==//
//
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
// See https://llvm.org/LICENSE.txt for license information.
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
//
//===----------------------------------------------------------------------===//
// This test checks that sub_group::store supports const reference.
//===----------------------------------------------------------------------===//
#include <CL/sycl.hpp>
using namespace sycl;

void test(intel::sub_group sg, global_ptr<int> ptr) { sg.store(ptr, 1); }