[SYCL][ABI-Break] ABI-neutralize has-kernel #13447
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Byoungro So <byoungro.so@intel.com>
bso-intel
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
bso-intel
commented
Apr 16, 2024
bso-intel
changed the title
bso-intel
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
Signed-off-by: Byoungro So <byoungro.so@intel.com>
bso-intel
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
bso-intel
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
bso-intel
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
bso-intel
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
bso-intel
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
Signed-off-by: Byoungro So <byoungro.so@intel.com>
steffenlarsen
approved these changes
Jul 18, 2024
Contributor
steffenlarsen
left a comment
steffenlarsen
left a comment
There was a problem hiding this comment.
Overall it looks good, but we should not export the symbols that are inline in the headers. Please address these, then I'm alright with merging this.
Co-authored-by: Steffen Larsen <steffen.larsen@intel.com>
Co-authored-by: Steffen Larsen <steffen.larsen@intel.com>
Co-authored-by: Steffen Larsen <steffen.larsen@intel.com>
bso-intel
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
Contributor
Author
|
@intel/llvm-gatekeepers |
bso-intel
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.