Skip to content

Conversation

@0x12CC
Copy link
Contributor

@0x12CC 0x12CC commented May 4, 2024

Includes the following changes:

Includes the following changes:
- Fix the `get_local_range`, `get_max_local_range`, `get_local_linear_range`
  tests. The expected values now match the extension specification.
- Re-enable the test case on L0. It should pass once
  oneapi-src/unified-runtime#1581 is merged.

Signed-off-by: Michael Aziz <michael.aziz@intel.com>
@0x12CC 0x12CC changed the title Fix root group test case [SYCL] Fix root group test case May 4, 2024
@0x12CC 0x12CC temporarily deployed to WindowsCILock May 4, 2024 02:16 — with GitHub Actions Inactive
@0x12CC 0x12CC temporarily deployed to WindowsCILock May 4, 2024 02:39 — with GitHub Actions Inactive
0x12CC added 2 commits May 6, 2024 13:51
Signed-off-by: Michael Aziz <michael.aziz@intel.com>
Signed-off-by: Michael Aziz <michael.aziz@intel.com>
@0x12CC 0x12CC temporarily deployed to WindowsCILock May 6, 2024 21:12 — with GitHub Actions Inactive
@0x12CC 0x12CC temporarily deployed to WindowsCILock May 6, 2024 22:32 — with GitHub Actions Inactive
Signed-off-by: Michael Aziz <michael.aziz@intel.com>
@kbenzie kbenzie marked this pull request as ready for review May 27, 2024 10:07
@kbenzie kbenzie requested review from a team as code owners May 27, 2024 10:07
@kbenzie kbenzie requested a review from cperkinsintel May 27, 2024 10:07
Copy link
Contributor

@steffenlarsen steffenlarsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@steffenlarsen steffenlarsen merged commit 0cb5307 into intel:sycl May 29, 2024
@0x12CC 0x12CC deleted the root_group_test_fix branch May 29, 2024 13:54
@steffenlarsen
Copy link
Contributor

@0x12CC @kbenzie - The test seems to fail in post-commit after this commit.

@kbenzie
Copy link
Contributor

kbenzie commented May 30, 2024

@0x12CC @kbenzie - The test seems to fail in post-commit after this commit.

FYI @nrspruit

Is there a link to the failure?

Edit: Might be unrelated but does this feature depend on a newer driver version than post commit uses, similar to here?

@steffenlarsen
Copy link
Contributor

See for example https://github.com/intel/llvm/actions/runs/9284287262/job/25547071272:

******************** TEST 'SYCL :: GroupAlgorithm/root_group.cpp' FAILED ********************
Exit Code: -6

Command Output (stdout):
--
# RUN: at line 3
/__w/llvm/llvm/toolchain/bin//clang++   -fsycl -fsycl-targets=spir64  /__w/llvm/llvm/llvm/sycl/test-e2e/GroupAlgorithm/root_group.cpp -I . -o /__w/llvm/llvm/build-e2e/GroupAlgorithm/Output/root_group.cpp.tmp.out
# executed command: /__w/llvm/llvm/toolchain/bin//clang++ -fsycl -fsycl-targets=spir64 /__w/llvm/llvm/llvm/sycl/test-e2e/GroupAlgorithm/root_group.cpp -I . -o /__w/llvm/llvm/build-e2e/GroupAlgorithm/Output/root_group.cpp.tmp.out
# note: command had no output on stdout or stderr
# RUN: at line 4
env ONEAPI_DEVICE_SELECTOR=level_zero:gpu  /__w/llvm/llvm/build-e2e/GroupAlgorithm/Output/root_group.cpp.tmp.out
# executed command: env ONEAPI_DEVICE_SELECTOR=level_zero:gpu /__w/llvm/llvm/build-e2e/GroupAlgorithm/Output/root_group.cpp.tmp.out
# .---command stderr------------
# | terminate called after throwing an instance of 'sycl::_V1::runtime_error'
# |   what():  Native API failed. Native API returns: -2 (PI_ERROR_DEVICE_NOT_AVAILABLE) -2 (PI_ERROR_DEVICE_NOT_AVAILABLE)
# `-----------------------------
# error: command failed with exit status: -6

--

@steffenlarsen
Copy link
Contributor

Test disabled for DG2 in #13984. An internal tracker for investigating the issue has been submitted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants