[SYCL][COMPAT] kernel_function and kernel_library constexpr constructors #13932
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Alcpz
force-pushed
the
Alcpz/constexpr-kernels
branch
from
9b5334d to
cd872a7
Compare
Signed-off-by: Alberto Cabrera <alberto.cabrera@codeplay.com>
Alcpz
force-pushed
the
Alcpz/constexpr-kernels
branch
from
cd872a7 to
c720017
Compare
Contributor
Author
|
@intel/llvm-gatekeepers Ready for merging. Issue is unrelated to our code (Affects Graphs which already have plenty of issues regarding failing tests). Thanks! |
Contributor
@Alcpz - I do not see any issues with the failing test. If you think it is related to an open issue, please mention in that issue that the test failed for this PR and link the issue here. |
Contributor
Author
|
@steffenlarsen My bad. I was looking at the wrong action. Here is the link to the issue |
Contributor
|
Thank you! Let's get it merged. 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated classes in
sycl/include/syclcompat/kernel.hppto have constexpr constructors and align to SYCLomatic's latestkernel.hppheader.