Skip to content

[ESIMD]Add static_asserts to existing autodeduction API #13977

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 31, 2024
Merged

[ESIMD]Add static_asserts to existing autodeduction API #13977

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2c63c70
Add static_asserts to existing autodeduction API
fineg74 May 30, 2024
630f473
Updated asserts
fineg74 May 31, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 25 additions & 2 deletions sycl/include/sycl/ext/intel/esimd/memory.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -623,6 +623,10 @@ __ESIMD_API std::enable_if_t<
simd<T, N>>
gather(const T *p, OffsetSimdViewT byte_offsets, simd_mask<N / VS> mask,
PassThruSimdViewT pass_thru, PropertyListT props = {}) {
static_assert(N / VS ==
OffsetSimdViewT::getSizeX() * OffsetSimdViewT::getSizeY(),
"Size of pass_thru parameter must correspond to the size of "
"byte_offsets parameter.");
return gather<T, N, VS>(p, byte_offsets.read(), mask, pass_thru.read(),
props);
}
Expand Down Expand Up @@ -662,6 +666,10 @@ __ESIMD_API std::enable_if_t<
simd<T, N>>
gather(const T *p, OffsetSimdViewT byte_offsets, simd_mask<N / VS> mask,
simd<T, N> pass_thru, PropertyListT props = {}) {
static_assert(N / VS ==
OffsetSimdViewT::getSizeX() * OffsetSimdViewT::getSizeY(),
"Size of pass_thru parameter must correspond to the size of "
"byte_offsets parameter.");
return gather<T, N, VS>(p, byte_offsets.read(), mask, pass_thru, props);
}

Expand Down Expand Up @@ -1012,6 +1020,10 @@ __ESIMD_API std::enable_if_t<
ext::oneapi::experimental::is_property_list_v<PropertyListT>>
scatter(T *p, OffsetSimdViewT byte_offsets, ValuesSimdViewT vals,
simd_mask<N / VS> mask, PropertyListT props = {}) {
static_assert(N / VS ==
OffsetSimdViewT::getSizeX() * OffsetSimdViewT::getSizeY(),
"Size of vals parameter must correspond to the size of "
"byte_offsets parameter.");
scatter<T, N, VS>(p, byte_offsets.read(), vals.read(), mask, props);
}

Expand Down Expand Up @@ -1116,6 +1128,10 @@ __ESIMD_API std::enable_if_t<
ext::oneapi::experimental::is_property_list_v<PropertyListT>>
scatter(T *p, OffsetSimdViewT byte_offsets, simd<T, N> vals,
simd_mask<N / VS> mask, PropertyListT props = {}) {
static_assert(N / VS ==
OffsetSimdViewT::getSizeX() * OffsetSimdViewT::getSizeY(),
"Size of vals parameter must correspond to the size of "
"byte_offsets parameter.");
scatter<T, N, VS>(p, byte_offsets.read(), vals, mask, props);
}

Expand Down Expand Up @@ -1150,6 +1166,10 @@ __ESIMD_API std::enable_if_t<
ext::oneapi::experimental::is_property_list_v<PropertyListT>>
scatter(T *p, OffsetSimdViewT byte_offsets, simd<T, N> vals,
PropertyListT props = {}) {
static_assert(N / VS ==
OffsetSimdViewT::getSizeX() * OffsetSimdViewT::getSizeY(),
"Size of vals parameter must correspond to the size of "
"byte_offsets parameter.");
scatter<T, N, VS>(p, byte_offsets.read(), vals, props);
}

Expand Down Expand Up @@ -1221,8 +1241,11 @@ __ESIMD_API std::enable_if_t<
ext::oneapi::experimental::is_property_list_v<PropertyListT>>
scatter(T *p, OffsetSimdViewT byte_offsets, ValuesSimdViewT vals,
PropertyListT props = {}) {
simd_mask<N / VS> Mask = 1;
scatter<T, N, VS>(p, byte_offsets.read(), vals.read(), Mask, props);
static_assert(N / VS ==
OffsetSimdViewT::getSizeX() * OffsetSimdViewT::getSizeY(),
"Size of vals parameter must correspond to the size of "
"byte_offsets parameter.");
scatter<T, N, VS>(p, byte_offsets.read(), vals.read(), props);
}

/// A variation of \c scatter API with \c offsets represented as scalar.
Expand Down