Skip to content

Conversation

@EwanC
Copy link
Contributor

@EwanC EwanC commented Jun 6, 2024

test-e2e/Graph/Explicit/add_nodes_after_finalize.cpp has been reported as failing on an unrelated PR on Windows - #11852 (comment)

Disable this test in line with how other flaky graphs tests have been disabled on Windows in #13966

The RecordReplay equivalent of this Explicit test is already disabled on Windows.

@EwanC EwanC temporarily deployed to WindowsCILock June 6, 2024 08:27 — with GitHub Actions Inactive
@EwanC EwanC temporarily deployed to WindowsCILock June 6, 2024 08:39 — with GitHub Actions Inactive
`test-e2e/Graph/Explicit/add_nodes_after_finalize.cpp` has
been reported as failing on an unrelated PR on Windows - intel#11852 (comment)

Disable this test in line with how other flaky graphs tests
have been disabled on Windows intel#13966

The `RecordReplay` equivalent of this Explicit test is already disabled
on Windows.
@EwanC EwanC force-pushed the ewan/disable_another_flaky_windows_test branch from 2185f53 to 5cc8341 Compare June 10, 2024 08:05
@EwanC EwanC temporarily deployed to WindowsCILock June 10, 2024 08:06 — with GitHub Actions Inactive
@EwanC EwanC temporarily deployed to WindowsCILock June 10, 2024 08:19 — with GitHub Actions Inactive
@EwanC EwanC marked this pull request as ready for review June 10, 2024 10:56
@EwanC EwanC requested a review from a team as a code owner June 10, 2024 10:56
@EwanC
Copy link
Contributor Author

EwanC commented Jun 10, 2024

@intel/llvm-gatekeepers Please merge this

@steffenlarsen steffenlarsen merged commit c98a37f into intel:sycl Jun 10, 2024
ianayl pushed a commit to ianayl/sycl that referenced this pull request Jun 13, 2024
`test-e2e/Graph/Explicit/add_nodes_after_finalize.cpp` has been reported
as failing on an unrelated PR on Windows -
intel#11852 (comment)

Disable this test in line with how other flaky graphs tests have been
disabled on Windows in intel#13966

The `RecordReplay` equivalent of this Explicit test is already disabled
on Windows.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants