[DeviceSanitizer] Don't instrument referenced-indirectly functions #14298
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When we create SLM __AsanLaunchInfo and store newly added kernel arg __asan_launch into the SLM, the SLM is loaded in asan report function. If instructions in referenced-indirectly function are instrumented, the report function is called. However, access to SLM in referenced- indirectly function isn't supported in intel-graphics-compiler yet.
AllanZyne
reviewed
Jun 27, 2024
wenju-he
commented
Jun 28, 2024
| return false; | ||
|
|
||
| if (TargetTriple.isSPIR()) { | ||
| if (F.getName().contains("__sycl_service_kernel__")) |
Contributor
Author
There was a problem hiding this comment.
@AllanZyne the name check might not be accurate, what if there is a user function that is xx__sycl_service_kernel__xx?
Contributor
There was a problem hiding this comment.
I think either way is okay.
As far as I know, currently this kernel naming style is only used for assert.
llvm/sycl/include/sycl/queue.hpp:2908
AllanZyne
approved these changes
Jun 28, 2024
Contributor
Author
|
@intel/llvm-gatekeepers please merge, thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we create SLM __AsanLaunchInfo and store newly added kernel arg __asan_launch into the SLM, the SLM is loaded in asan report function. If instructions in referenced-indirectly function are instrumented, the report function is called. However, access to SLM in referenced- indirectly function isn't supported in intel-graphics-compiler yet.