[SYCL] Don't throw in device_impl::has
#14355
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1) It isn't right 2) We need this change to get rid of deprecated `sycl::exception::get_cl_code`
Contributor
Please, don't write description like that. Instead put an answer to "why it's not right?". |
Contributor
Author
|
I'd be happy to have a discussion with somebody who can explain to me how it might make even a tiniest bit of sense for a "has" method to throw an exception. Until then, "it isn't right" is pretty much how I see it. |
aelovikov-intel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
aelovikov-intel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
KseniyaTikhomirova
pushed a commit
to KseniyaTikhomirova/llvm
that referenced
this pull request
Jul 1, 2024
1) It isn't right 2) We need this change to get rid of deprecated `sycl::exception::get_cl_code`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sycl::exception::get_cl_code