[SYCL] Change the ext_intel_device_info spec to throw a feature not supported error when a query is not supported #14576
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… is not supported
gmlueck
reviewed
Jul 16, 2024
Co-authored-by: Greg Lueck <gregory.m.lueck@intel.com>
gmlueck
approved these changes
Jul 16, 2024
Contributor
Author
|
@intel/llvm-gatekeepers This looks ready for merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When an aspect is not supported by a device, the
ext_intel_device_infospec says to throw an invalid object runtime error when callingget_infowith the corresponding descriptor. This error description is both vague and not very descriptive of the actual thing that went wrong, namely that the query is simply not supported by a device. This PR changes that to instead say to throw a feature not supported runtime error.