[SYCL-JIT] Store env variables in configuration #14860
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch renames the directory (`sycl-fusion` to `sycl-jit`) as well as the involved library names (following the same principle: `fusion` to `jit`). To keep the user facing names consistent buildbot switches were updated. And finally the codeowners file had to reflect the directory change.
…_DIR SYCL_ENABLE_KERNEL_FUSION -> SYCL_ENABLE_EXTENSION_JIT SYCL_FUSION_INCLUDE_DIRS -> SYCL_JIT_INCLUDE_DIRS
SYCL_FUSION_ENABLE_WERROR -> SYCL_JIT_ENABLE_WERROR FUSION_JIT_SUPPORT_PTX -> JIT_SUPPORT_PTX FUSION_JIT_SUPPORT_AMDGCN -> JIT_SUPPORT_AMDGCN
By storing the env variables in the config helper we eliminate the need for extra function parameters while also making it accessible throughout the codebase.
jchlanda
changed the title
victor-eds
reviewed
Aug 12, 2024
victor-eds
reviewed
Aug 13, 2024
jchlanda
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
jchlanda
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
victor-eds
reviewed
Aug 13, 2024
victor-eds
reviewed
Aug 20, 2024
sommerlukas
approved these changes
Aug 21, 2024
jchlanda
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
dyniols
pushed a commit
to dyniols/llvm
that referenced
this pull request
Aug 21, 2024
By storing the env variables in the config helper we eliminate the need for extra function parameters while also making it accessible throughout the codebase.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By storing the env variables in the config helper we eliminate the need
for extra function parameters while also making it accessible throughout
the codebase.