[SYCL] Rename SYCL_ENABLE_PLUGINS to SYCL_ENABLE_BACKENDS #14931
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martygrant
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
kbenzie
reviewed
Aug 2, 2024
martygrant
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
martygrant
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
againull
approved these changes
Aug 6, 2024
againull
changed the title
aarongreig
approved these changes
Aug 9, 2024
Also rename SYCL_PI_UR_USE_FETCH_CONTENT to SYCL_UR_USE_FETCH_CONTENT and SYCL_PI_UR_SOURCE_DIR to SYCL_UR_SOURCE_DIR.
Tell user they should use SYCL_ENABLE_BACKENDS instead. Use the value given for the old flag for the new flag.
martygrant
force-pushed
the
martin/renameSYCL_ENABLE_PLUGINS
branch
from
6c0d1d3 to
60ecb9d
Compare
martygrant
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
martygrant
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
PietroGhg
approved these changes
Aug 12, 2024
Contributor
PietroGhg
left a comment
PietroGhg
left a comment
There was a problem hiding this comment.
Native CPU LGTM, thank you
Contributor
Author
|
@intel/dpcpp-devops-reviewers could someone from this team take a look at this PR please? thanks! |
martygrant
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
martygrant
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
kbenzie
approved these changes
Aug 12, 2024
steffenlarsen
approved these changes
Aug 12, 2024
Contributor
steffenlarsen
left a comment
steffenlarsen
left a comment
There was a problem hiding this comment.
LGTM! Thanks for adding the safety-net-with-warning path!
Contributor
Author
|
@intel/llvm-gatekeepers this is now ready for merge, please and thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rename
SYCL_ENABLE_PLUGINStoSYCL_ENABLE_BACKENDSAlso rename
SYCL_PI_UR_USE_FETCH_CONTENTtoSYCL_UR_USE_FETCH_CONTENTand
SYCL_PI_UR_SOURCE_DIRtoSYCL_UR_SOURCE_DIRFor #14927