[SYCL][UR] Pull in update that changes urDeviceCreateWithNativeHandle. #15023
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aarongreig
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
aarongreig
force-pushed
the
aaron/updateURDeviceCreateWithNative
branch
from
9d85c6d to
d2f00ec
Compare
aarongreig
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
aarongreig
force-pushed
the
aaron/updateURDeviceCreateWithNative
branch
from
d2f00ec to
55d261d
Compare
aarongreig
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
aarongreig
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
The api now takes a ur_adapter_handle_t instead of a ur_platform_handle_t, which is easier for sycl RT to correctly provide and enables a fix for a few instances where we were illegally passing nullptr.
omarahmed1111
force-pushed
the
aaron/updateURDeviceCreateWithNative
branch
from
55d261d to
bbf2abe
Compare
omarahmed1111
approved these changes
Aug 15, 2024
omarahmed1111
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
omarahmed1111
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
Contributor
|
@intel/llvm-reviewers-runtime Please review, Thanks! |
Contributor
|
@intel/llvm-gatekeepers Please merge, Thanks! |
AlexeySachkov
pushed a commit
to AlexeySachkov/llvm
that referenced
this pull request
Nov 26, 2024
intel#15023) The api now takes a ur_adapter_handle_t instead of a ur_platform_handle_t, which is easier for sycl RT to correctly provide and enables a fix for a few instances where we were illegally passing nullptr.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The api now takes a ur_adapter_handle_t instead of a ur_platform_handle_t, which is easier for sycl RT to correctly provide and enables a fix for a few instances where we were illegally passing nullptr.