[SYCL] Fix OpenCL C to spirv kernel_compiler for the multi-device case #15099
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
againull
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
Currently if there is only single device in the context then kernel compiler passes ip version of that device via -device option to ocloc when compiling OpenCL program to spirv to let ocloc enable all extensions supported by that device. Problem is that ocloc -spv_only doesn't produce spirv file when multiple devices are provided via -device option. That's why in this case enable common extensions supported by all devices manually. To do that use ocloc query to get common supported features for the list of devices and then process the return and enable features via ocloc -internal_options -cl-ext=+feature1,...
againull
force-pushed
the
opencl_to_spirv_multi_device
branch
from
7f92809 to
d8f0f05
Compare
AlexeySachkov
pushed a commit
to AlexeySachkov/llvm
that referenced
this pull request
Nov 26, 2024
intel#15099) Currently if there is only single device in the context then kernel compiler passes ip version of that device via -device option to ocloc when compiling OpenCL program to spirv to let ocloc enable all extensions supported by that device. Problem is that ocloc -spv_only doesn't produce spirv file when multiple devices are provided via -device option. That's why in this case enable common extensions supported by all devices manually. To do that use ocloc query to get common supported features for the list of devices and then process the return and enable features via ocloc -internal_options -cl-ext=+feature1,...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently if there is only single device in the context then kernel
compiler passes ip version of that device via -device option to ocloc
when compiling OpenCL program to spirv to let ocloc enable all extensions
supported by that device. Problem is that ocloc -spv_only doesn't produce
spirv file when multiple devices are provided via -device option.
That's why in this case enable common extensions supported by all devices
manually. To do that use ocloc query to get common supported features
for the list of devices and then process the return and enable features
via ocloc -internal_options -cl-ext=+feature1,...