Skip to content

[SYCL][NATIVECPU] Fix missing declarations for broadcast and shuffle operations #15140

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 21, 2024
Merged

[SYCL][NATIVECPU] Fix missing declarations for broadcast and shuffle operations #15140

merged 1 commit into from
Aug 21, 2024

Conversation

@coldav
Copy link

@coldav coldav commented Aug 20, 2024

Multiple declarations were missing for shuffle and broadcast operations, in particular work group broadcast ones. This adds them.

@coldav coldav requested a review from a team as a code owner August 20, 2024 10:27
@coldav coldav requested a review from dm-vodopyanov August 20, 2024 10:27
@dm-vodopyanov
Copy link
Contributor

@coldav, hello, please follow https://github.com/intel/llvm/blob/sycl/sycl/doc/developer/ContributeToDPCPP.md#commit-message

[SYCL][NATIVECPU] Fix missing declarations for broadcast and shuffle …
69b9997 
…operations

Multiple declarations were missing for shuffle and broadcast operations,
in particular work group broadcast ones.
@coldav coldav force-pushed the colin/fix_broadcast_shuffle branch from 75096ac to 69b9997 Compare August 20, 2024 16:00
@coldav coldav requested a review from a team as a code owner August 20, 2024 16:00
@coldav coldav changed the title Fix missing declarations for broadcast and shuffle operations [SYCL][NATIVECPU] Fix missing declarations for broadcast and shuffle operations Aug 20, 2024
@coldav
Copy link
Author

coldav commented Aug 20, 2024

@coldav, hello, please follow https://github.com/intel/llvm/blob/sycl/sycl/doc/developer/ContributeToDPCPP.md#commit-message

This should be done now.

@dm-vodopyanov
Copy link
Contributor

@coldav, hello, please follow https://github.com/intel/llvm/blob/sycl/sycl/doc/developer/ContributeToDPCPP.md#commit-message

This should be done now.

Thank you.

Should there be some tests in the patch?

@coldav
Copy link
Author

coldav commented Aug 21, 2024

@coldav, hello, please follow https://github.com/intel/llvm/blob/sycl/sycl/doc/developer/ContributeToDPCPP.md#commit-message

This should be done now.

Thank you.

Should there be some tests in the patch?

No, I think e2e covers quite well, along with sycl cts.

@dm-vodopyanov
Copy link
Contributor

@coldav, hello, please follow https://github.com/intel/llvm/blob/sycl/sycl/doc/developer/ContributeToDPCPP.md#commit-message

This should be done now.

Thank you.
Should there be some tests in the patch?

No, I think e2e covers quite well, along with sycl cts.

This patch adds new functionality, were there any e2e and/or CTS tests that failed due to lack of this?

@coldav
Copy link
Author

coldav commented Aug 21, 2024 •
edited
Loading

@coldav, hello, please follow https://github.com/intel/llvm/blob/sycl/sycl/doc/developer/ContributeToDPCPP.md#commit-message

This should be done now.

Thank you.
Should there be some tests in the patch?

No, I think e2e covers quite well, along with sycl cts.

This patch adds new functionality, were there any e2e and/or CTS tests that failed due to lack of this?

For native cpu yes, there were multiple errors from native cpu both on SYCL CTS and e2e (shown as link errors). We currently run those tests downstream until such time as we are able to pass all.

dm-vodopyanov
dm-vodopyanov approved these changes Aug 21, 2024
View reviewed changes
Copy link
Contributor

@dm-vodopyanov dm-vodopyanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM!

@coldav
Copy link
Author

coldav commented Aug 21, 2024

@intel/llvm-gatekeepers please merge.

@againull againull merged commit de8aefb into intel:sycl Aug 21, 2024
dyniols pushed a commit to dyniols/llvm that referenced this pull request Aug 21, 2024
@dyniols
[SYCL][NATIVECPU] Fix missing declarations for broadcast and shuffle…
4f44b1a 
… operations (intel#15140)

Multiple declarations were missing for shuffle and broadcast operations,
in particular work group broadcast ones. This adds them.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dm-vodopyanov dm-vodopyanov dm-vodopyanov approved these changes

+1 more reviewer

@PietroGhg PietroGhg PietroGhg approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@coldav @dm-vodopyanov @PietroGhg @againull