Skip to content

Conversation

@Nuullll
Copy link
Contributor

@Nuullll Nuullll commented Aug 22, 2024

The aspect is supported since OpenCL CPU 2024.2

@Nuullll Nuullll requested review from a team as code owners August 22, 2024 11:43
@Nuullll Nuullll requested a review from dm-vodopyanov August 22, 2024 11:43
dm-vodopyanov
dm-vodopyanov previously approved these changes Aug 22, 2024
@dm-vodopyanov dm-vodopyanov dismissed their stale review August 22, 2024 13:00

Approve retracted

@Nuullll
Copy link
Contributor Author

Nuullll commented Aug 26, 2024

ping @intel/dpcpp-tools-reviewers @dm-vodopyanov
I don't think the precommit failures are relevant with this change.

@Nuullll
Copy link
Contributor Author

Nuullll commented Aug 27, 2024

ping @intel/dpcpp-tools-reviewers @dm-vodopyanov

@Nuullll
Copy link
Contributor Author

Nuullll commented Aug 27, 2024

@intel/llvm-gatekeepers Could you please merge this?

@Nuullll Nuullll changed the title [CPU] Add ext_oneapi_ballot_group aspect to spir64_x86_64 target [SYCL][CPU] Add ext_oneapi_ballot_group aspect to spir64_x86_64 target Aug 28, 2024
@Nuullll
Copy link
Contributor Author

Nuullll commented Aug 29, 2024

ping @intel/llvm-gatekeepers

@Nuullll
Copy link
Contributor Author

Nuullll commented Aug 29, 2024

@intel/dpcpp-tools-reviewers could you please approve this?

@Nuullll Nuullll requested a review from a team August 29, 2024 09:55
@martygrant martygrant merged commit 3f2b2dd into intel:sycl Aug 29, 2024
// RUN: %{run} %t.out
//
// REQUIRES: gpu
// REQUIRES: cpu, gpu
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will never run. Did you mean cpu || gpu?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you. #15236

againull pushed a commit that referenced this pull request Aug 30, 2024
Follow-up of #15165
The test should run on either CPU or GPU.
AlexeySachkov pushed a commit to AlexeySachkov/llvm that referenced this pull request Nov 26, 2024
Follow-up of intel#15165
The test should run on either CPU or GPU.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants