[SYCL][COMPAT] Convert error names to lower case #15373
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This avoids a clash with e.g. `#define SUCCESS 0` in another header somewhere.
This is a breaking change, but bumping major version would move us out of Pre-Release, so 0.2.0?
joeatodd
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
joeatodd
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
I agree with bumping the version. Nit: Wrt the PR message, I changed the description as that is turned into the commit message of the merge commit, and the quoted part reads as a conversation. For discussion: Are we certain no one is using these error codes already? We would need to introduce deprecated error_codes otherwise. |
|
After discussion with @joeatodd, let's proceed with the merge as we are still in pre-release |
Alcpz
approved these changes
Sep 13, 2024
joeatodd
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
|
@intel/llvm-gatekeepers this is ready to merge 🙏 CI failures unrelated |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is done to avoid conflict with upper-case macros redefining e.g.
SUCCESS.I'm also bumping to
0.2.0.