-
Notifications
You must be signed in to change notification settings - Fork 791
[SYCL][COMPAT] Add get_error_string_dummy() function #15719
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Jiang, Zhiwei <zhiwei.jiang@intel.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this @zhiweij1! I have just made one small suggestion about the comments.
Signed-off-by: Jiang, Zhiwei <zhiwei.jiang@intel.com>
|
Hi @joeatodd, it seems the CI failure is not related to this PR. The failures are not compile fail. Can this PR be merged? |
Yes I've made an issue to describe the unrelated test failures which are occurring across several unrelated PRs. |
|
@intel/llvm-gatekeepers this is ready to merge. Unrelated test failures described here. |
|
All passing, ready to merge @intel/llvm-gatekeepers 👍 |
Signed-off-by: Jiang, Zhiwei zhiwei.jiang@intel.com