Skip to content

Conversation

@zhiweij1
Copy link
Contributor

Signed-off-by: Jiang, Zhiwei zhiwei.jiang@intel.com

Signed-off-by: Jiang, Zhiwei <zhiwei.jiang@intel.com>
@zhiweij1 zhiweij1 requested a review from a team as a code owner October 16, 2024 08:29
Copy link
Contributor

@tomflinda tomflinda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

@zhimingwang36 zhimingwang36 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@joeatodd joeatodd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this @zhiweij1! I have just made one small suggestion about the comments.

Signed-off-by: Jiang, Zhiwei <zhiwei.jiang@intel.com>
@zhiweij1
Copy link
Contributor Author

zhiweij1 commented Oct 17, 2024

Hi @joeatodd, it seems the CI failure is not related to this PR. The failures are not compile fail. Can this PR be merged?

********************
Expectedly Failed Tests (1):
  SYCL :: VirtualFunctions/misc/group-barrier.cpp

********************
Failed Tests (2):
  SYCL :: syclcompat/memory/usm_allocations.cpp
  SYCL :: syclcompat/util/util_shift_sub_group_right.cpp


Testing Time: 2556.64s

Total Discovered Tests: 2212
  Unsupported      :  701 (31.69%)
  Passed           : 1508 (68.17%)
  Expectedly Failed:    1 (0.05%)
  Failed           :    2 (0.09%)

@joeatodd
Copy link
Contributor

Hi @joeatodd, it seems the CI failure is not related to this PR. The failures are not compile fail. Can this PR be merged?

********************
Expectedly Failed Tests (1):
  SYCL :: VirtualFunctions/misc/group-barrier.cpp

********************
Failed Tests (2):
  SYCL :: syclcompat/memory/usm_allocations.cpp
  SYCL :: syclcompat/util/util_shift_sub_group_right.cpp


Testing Time: 2556.64s

Total Discovered Tests: 2212
  Unsupported      :  701 (31.69%)
  Passed           : 1508 (68.17%)
  Expectedly Failed:    1 (0.05%)
  Failed           :    2 (0.09%)

Yes I've made an issue to describe the unrelated test failures which are occurring across several unrelated PRs.

@joeatodd
Copy link
Contributor

@intel/llvm-gatekeepers this is ready to merge. Unrelated test failures described here.

@steffenlarsen
Copy link
Contributor

@joeatodd - Based on #15737 it should be passing again. Would you mind pushing a merge-commit to make sure it is fully unrelated to these changes?

@joeatodd
Copy link
Contributor

All passing, ready to merge @intel/llvm-gatekeepers 👍

@sommerlukas sommerlukas merged commit 07fbce2 into intel:sycl Oct 18, 2024
12 checks passed
@zhiweij1 zhiweij1 deleted the get_error_string_dummy branch October 18, 2024 07:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants