[clang][SYCL] Emit canonical types in integration footer #16161
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A recent change to sycl headers revealed a bug in integration footer - missing nns in case of an explicit template specialization in some of device_globa's template arguments.
Fznamznon
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
Fznamznon
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
premanandrao
approved these changes
Nov 22, 2024
Contributor
premanandrao
left a comment
premanandrao
left a comment
There was a problem hiding this comment.
LGTM, except for additional comments in the test.
Fznamznon
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
Fznamznon
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
Contributor
Author
|
@intel/llvm-gatekeepers , this is ready, please merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A recent change to sycl headers revealed a bug in integration footer - missing nns in case of an explicit template specialization in some of device_global's template arguments.