Skip to content

[SYCL][NFC] Use move on queue parameters #16326

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 12, 2024
Merged

[SYCL][NFC] Use move on queue parameters #16326

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions sycl/source/detail/kernel_impl.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -355,7 +355,8 @@ inline typename syclex::info::kernel_queue_specific::max_num_work_groups::
syclex::info::kernel_queue_specific::max_num_work_groups>(
queue Queue, const range<1> &WorkGroupSize,
size_t DynamicLocalMemorySize) const {
return queryMaxNumWorkGroups(Queue, WorkGroupSize, DynamicLocalMemorySize);
return queryMaxNumWorkGroups(std::move(Queue), WorkGroupSize,
DynamicLocalMemorySize);
}

template <>
Expand All @@ -365,7 +366,8 @@ inline typename syclex::info::kernel_queue_specific::max_num_work_groups::
syclex::info::kernel_queue_specific::max_num_work_groups>(
queue Queue, const range<2> &WorkGroupSize,
size_t DynamicLocalMemorySize) const {
return queryMaxNumWorkGroups(Queue, WorkGroupSize, DynamicLocalMemorySize);
return queryMaxNumWorkGroups(std::move(Queue), WorkGroupSize,
DynamicLocalMemorySize);
}

template <>
Expand All @@ -375,7 +377,8 @@ inline typename syclex::info::kernel_queue_specific::max_num_work_groups::
syclex::info::kernel_queue_specific::max_num_work_groups>(
queue Queue, const range<3> &WorkGroupSize,
size_t DynamicLocalMemorySize) const {
return queryMaxNumWorkGroups(Queue, WorkGroupSize, DynamicLocalMemorySize);
return queryMaxNumWorkGroups(std::move(Queue), WorkGroupSize,
DynamicLocalMemorySize);
}

} // namespace detail
Expand Down
12 changes: 6 additions & 6 deletions sycl/source/kernel.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,30 +108,30 @@ kernel::get_info<info::kernel_device_specific::max_sub_group_size>(
template <typename Param>
typename detail::is_kernel_queue_specific_info_desc<Param>::return_type
kernel::ext_oneapi_get_info(queue Queue) const {
return impl->ext_oneapi_get_info<Param>(Queue);
return impl->ext_oneapi_get_info<Param>(std::move(Queue));
}

template <typename Param>
typename detail::is_kernel_queue_specific_info_desc<Param>::return_type
kernel::ext_oneapi_get_info(queue Queue, const range<1> &WorkGroupSize,
size_t DynamicLocalMemorySize) const {
return impl->ext_oneapi_get_info<Param>(Queue, WorkGroupSize,
return impl->ext_oneapi_get_info<Param>(std::move(Queue), WorkGroupSize,
DynamicLocalMemorySize);
}

template <typename Param>
typename detail::is_kernel_queue_specific_info_desc<Param>::return_type
kernel::ext_oneapi_get_info(queue Queue, const range<2> &WorkGroupSize,
size_t DynamicLocalMemorySize) const {
return impl->ext_oneapi_get_info<Param>(Queue, WorkGroupSize,
return impl->ext_oneapi_get_info<Param>(std::move(Queue), WorkGroupSize,
DynamicLocalMemorySize);
}

template <typename Param>
typename detail::is_kernel_queue_specific_info_desc<Param>::return_type
kernel::ext_oneapi_get_info(queue Queue, const range<3> &WorkGroupSize,
size_t DynamicLocalMemorySize) const {
return impl->ext_oneapi_get_info<Param>(Queue, WorkGroupSize,
return impl->ext_oneapi_get_info<Param>(std::move(Queue), WorkGroupSize,
DynamicLocalMemorySize);
}

Expand Down Expand Up @@ -185,7 +185,7 @@ __SYCL_EXPORT typename ext::oneapi::experimental::info::kernel_queue_specific::
size_t DynamicLocalMemorySize) const {
return ext_oneapi_get_info<ext::oneapi::experimental::info::
kernel_queue_specific::max_num_work_groups>(
Queue, WorkGroupSize, DynamicLocalMemorySize);
std::move(Queue), WorkGroupSize, DynamicLocalMemorySize);
}
template <>
__SYCL2020_DEPRECATED(
Expand All @@ -201,7 +201,7 @@ __SYCL_EXPORT typename ext::oneapi::experimental::info::kernel_queue_specific::
const sycl::range<3> WorkGroupSize{MaxWorkGroupSize, 1, 1};
return ext_oneapi_get_info<ext::oneapi::experimental::info::
kernel_queue_specific::max_num_work_groups>(
Queue, WorkGroupSize,
std::move(Queue), WorkGroupSize,
/* DynamicLocalMemorySize */ 0);
}
#endif
Expand Down
Loading