Skip to content

[SYCL] Fix crash in CompileTimePropertiesPass when pointer parameter of a function is annotated. #18590

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 26, 2025
Merged

[SYCL] Fix crash in CompileTimePropertiesPass when pointer parameter of a function is annotated. #18590

merged 3 commits into from
May 26, 2025

Conversation

maarquitos14
Copy link
Contributor

Fixes #17591.

@maarquitos14 maarquitos14 requested review from a team as code owners May 21, 2025 15:35
@maarquitos14 maarquitos14 requested a review from slawekptak May 21, 2025 15:35
@maarquitos14
Copy link
Contributor Author

FYI @aelovikov-intel

@maarquitos14 @aelovikov-intel
Update sycl/test/check_device_code/extensions/properties/properties_c…
d9abe2f 
…ache_control.cpp

Co-authored-by: aelovikov-intel <andrei.elovikov@intel.com>
@maarquitos14
Copy link
Contributor Author

@slawekptak @intel/dpcpp-tools-reviewers friendly ping.

maksimsab
maksimsab approved these changes May 23, 2025
View reviewed changes
Copy link
Contributor

@maksimsab maksimsab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

nit: there is a using namespace std; in the beginning of the file which allows to omit namespace's specifications.

@maarquitos14
Copy link
Contributor Author

LGTM!

nit: there is a using namespace std; in the beginning of the file which allows to omit namespace's specifications.

Thanks for bringing this up! I did see the namespace, but I also see in other parts of the file that we explicitly use llvm namespace, so I wasn't sure if we have any rule for that. Is there a preferred way? I have no preference so I don't mind changing it.

@steffenlarsen steffenlarsen merged commit 98165d3 into intel:sycl May 26, 2025
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aelovikov-intel aelovikov-intel aelovikov-intel left review comments

@steffenlarsen steffenlarsen steffenlarsen approved these changes

@maksimsab maksimsab maksimsab approved these changes

@slawekptak slawekptak Awaiting requested review from slawekptak slawekptak is a code owner automatically assigned from intel/llvm-reviewers-runtime

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Crash in CompileTimePropertiesPass when pointer parameter of a function is annotated

4 participants

@maarquitos14 @aelovikov-intel @steffenlarsen @maksimsab