Skip to content

[SYCL] Implement sycl_ext_oneapi_clock #19858

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 17 commits into from
Sep 11, 2025
Merged

[SYCL] Implement sycl_ext_oneapi_clock #19858

merged 17 commits into from
Sep 11, 2025

Conversation

KornevNikita
Copy link
Contributor

@KornevNikita KornevNikita commented Aug 22, 2025 •
edited
Loading

@steffenlarsen steffenlarsen self-requested a review August 25, 2025 04:46
KornevNikita
KornevNikita commented Aug 26, 2025
View reviewed changes
@KornevNikita KornevNikita marked this pull request as ready for review August 26, 2025 13:36
@KornevNikita KornevNikita requested a review from a team as a code owner August 26, 2025 13:36
dyniols
dyniols approved these changes Sep 1, 2025
View reviewed changes
Copy link
Contributor

@dyniols dyniols left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

steffenlarsen
steffenlarsen reviewed Sep 2, 2025
View reviewed changes
sycl/source/detail/device_impl.hpp Outdated
UR_DEVICE_INFO_MEMORY_EXPORT_EXPORTABLE_DEVICE_MEM_EXP>()
.value_or(0);
}
CASE(ext_oneapi_clock) { return has_extension("cl_khr_kernel_clock"); }
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be moved to the UR adaptors under a new device info query. Could you please open a tracker to remind us to do that?

steffenlarsen
steffenlarsen approved these changes Sep 2, 2025
View reviewed changes
Copy link
Contributor

@steffenlarsen steffenlarsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lookin' good! 🚀

@KornevNikita KornevNikita marked this pull request as ready for review September 9, 2025 13:34
@KornevNikita
Copy link
Contributor Author

Spec was merged. @steffenlarsen @maarquitos14 @dyniols take one more look please

steffenlarsen
steffenlarsen reviewed Sep 9, 2025
View reviewed changes
steffenlarsen
steffenlarsen approved these changes Sep 10, 2025
View reviewed changes
Copy link
Contributor

@steffenlarsen steffenlarsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

AlexeySachkov
AlexeySachkov approved these changes Sep 10, 2025
View reviewed changes
Copy link
Contributor

@AlexeySachkov AlexeySachkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DeviceConfigFile LGTM

dyniols
dyniols approved these changes Sep 10, 2025
View reviewed changes
Copy link
Contributor

@dyniols dyniols left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@KornevNikita KornevNikita requested review from a team as code owners September 10, 2025 17:58
@KornevNikita
Copy link
Contributor Author

@intel/unified-runtime-reviewers @intel/unified-runtime-reviewers-opencl sorry accidentally pushed to this branch, your review is not required.

@KornevNikita
Copy link
Contributor Author

KornevNikita commented Sep 11, 2025 •
edited by AlexeySachkov
Loading

fails:

  Failed Tests (1):
    SYCL :: Assert/assert_in_multiple_tus.cpp

#19951

  Failed Tests (1):
    SYCL :: KernelCompiler/sycl_device_globals.cpp

#19965

@AlexeySachkov AlexeySachkov removed request for a team September 11, 2025 08:56
@AlexeySachkov AlexeySachkov merged commit 2c7b9fc into intel:sycl Sep 11, 2025
52 of 55 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AlexeySachkov AlexeySachkov AlexeySachkov approved these changes

@maarquitos14 maarquitos14 maarquitos14 approved these changes

@steffenlarsen steffenlarsen steffenlarsen approved these changes

@dyniols dyniols dyniols approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@KornevNikita @AlexeySachkov @maarquitos14 @steffenlarsen @dyniols