[Benchmark] Fix benchmark dashboard failing to load metadata #20026
Conversation
|
@intel/llvm-reviewers-benchmarking Is anyone able to review this? The comparisons are not working right now on the dashboard. Would be nice if we can get this PR in before the nightly sycl-docs run |
Do you have a GHA run for this PR, to validate the changes? |
A GHA run won't change the dashboard, and thus won't be able to actually validate the changes. However, I can add a manual trigger to sycl-docs.yml, which would actually update the dashboard... so long as you're willing to review and approve it 😉 We do have https://github.com/intel/llvm/actions/runs/17590703763/job/49971844863?pr=20026 (as a part of precommit now), but it will not do anything w.r.t. the changes here |
Sounds good to me. |
|
Skipping pre-commit runs as the change is in benchmarking scripts. |
…20038) I made PR #20026 yesterday to fix a bug in the benchmarking CI dashboard, but looks like my changes were not deployed onto Github pages. This PR: - Adds benchmarking dashboard to the list of paths in workflow triggers - Adds a manual trigger to sycl-docs.yml, allowing people to manually trigger a github pages update if necessary in the future
2 participants
A previous PR removed these lines, causing metadata to no longer load in the benchmark dashboard. This PR restores these lines.