Skip to content

Conversation

YixingZhang007
Copy link
Contributor

@YixingZhang007 YixingZhang007 commented Sep 16, 2025

This PR re-enables SYCL end-to-end tests previously marked as XFAIL or UNSUPPORTED on the SPIR-V backend, as they now pass. For tests that are still failing, new issues have been created in llvm-project and added as XFAIL-TRACKER.

@YixingZhang007 YixingZhang007 requested review from a team as code owners September 16, 2025 18:03
@YixingZhang007 YixingZhang007 marked this pull request as draft September 16, 2025 18:03
@YixingZhang007 YixingZhang007 changed the title [SPIRV] Re-enable SYCL e2e tests marked XFAIL/Unsupported that pass with SPIR-V backend [E2E] Enable end-to-end tests supported by the SPIR-V backend Sep 16, 2025
// RUN: %{run} not %t.out 2>&1 | FileCheck %S/Inputs/host-usm-oob.cpp

// XFAIL: spirv-backend && arch-intel_gpu_pvc
// XFAIL-TRACKER: CMPLRLLVM-64052
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is meaningless for the upstream.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the suggestion! I've updated the xfail tracker to reference the issue in llvm-project instead of linking to the Jira issue.

@YixingZhang007 YixingZhang007 marked this pull request as ready for review September 26, 2025 17:42
@YixingZhang007 YixingZhang007 requested a review from a team as a code owner September 26, 2025 17:42
@steffenlarsen steffenlarsen removed the request for review from a team September 29, 2025 09:34
Copy link
Contributor

@maarquitos14 maarquitos14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just wondering if this should update the tests that check the number of unsupported and xfailed tests. @AlexeySachkov should it?

@AlexeySachkov
Copy link
Contributor

LGTM, just wondering if this should update the tests that check the number of unsupported and xfailed tests. @AlexeySachkov should it?

There is a test checking that and if it passes, then everything is good. Essentially, we are only tracking a number of XFAILs/UNSUPPORTED directives which are not followed by -TRACKER/-INTENDED directive. As long as modifications are made in pairs, i.e. both the main directive and a "follow-up" are present (or absent), then everything is fine.

We do not track tests disabled through lit.cfg, because the tracking mechanism is a simple grep

@YixingZhang007
Copy link
Contributor Author

YixingZhang007 commented Oct 3, 2025

LGTM, just wondering if this should update the tests that check the number of unsupported and xfailed tests. @AlexeySachkov should it?

There is a test checking that and if it passes, then everything is good. Essentially, we are only tracking a number of XFAILs/UNSUPPORTED directives which are not followed by -TRACKER/-INTENDED directive. As long as modifications are made in pairs, i.e. both the main directive and a "follow-up" are present (or absent), then everything is fine.

We do not track tests disabled through lit.cfg, because the tracking mechanism is a simple grep

Thank you for solving our concern! All the CI tests also pass.

@YixingZhang007
Copy link
Contributor Author

@intel/dpcpp-sanitizers-review All the CI tests have passed. Could you please help review this PR? Thank you!

Copy link
Contributor

@zhaomaosu zhaomaosu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

device sanitizer changes lgtm

Copy link
Contributor

github-actions bot commented Oct 9, 2025

@intel/llvm-gatekeepers please consider merging

1 similar comment
Copy link
Contributor

@intel/llvm-gatekeepers please consider merging

@aelovikov-intel aelovikov-intel merged commit 8c7e6c5 into intel:sycl Oct 13, 2025
29 checks passed
@aelovikov-intel
Copy link
Contributor

aelovikov-intel commented Oct 13, 2025

@YixingZhang007 , the following failed in post-commit:

Failed Tests (6):
SYCL :: Basic/image/image.cpp
SYCL :: Basic/image/image_array.cpp
SYCL :: Basic/image/srgba-read.cpp
SYCL :: Regression/group_load_fortified.cpp
SYCL :: bindless_images/array/read_write_unsampled_array.cpp
SYCL :: bindless_images/read_write_unsampled.cpp

Looks like you're on a public holiday today, so I'm reverting this.

aelovikov-intel added a commit that referenced this pull request Oct 13, 2025
#20355)

Reverts #20104

Post commit failed with

```
Failed Tests (6):
SYCL :: Basic/image/image.cpp
SYCL :: Basic/image/image_array.cpp
SYCL :: Basic/image/srgba-read.cpp
SYCL :: Regression/group_load_fortified.cpp
SYCL :: bindless_images/array/read_write_unsampled_array.cpp
SYCL :: bindless_images/read_write_unsampled.cpp
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants