-
Notifications
You must be signed in to change notification settings - Fork 791
[E2E] Enable end-to-end tests supported by the SPIR-V backend #20104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
// RUN: %{run} not %t.out 2>&1 | FileCheck %S/Inputs/host-usm-oob.cpp | ||
|
||
// XFAIL: spirv-backend && arch-intel_gpu_pvc | ||
// XFAIL-TRACKER: CMPLRLLVM-64052 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is meaningless for the upstream.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the suggestion! I've updated the xfail tracker to reference the issue in llvm-project instead of linking to the Jira issue.
d7f333b
to
dc8ee02
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just wondering if this should update the tests that check the number of unsupported and xfailed tests. @AlexeySachkov should it?
There is a test checking that and if it passes, then everything is good. Essentially, we are only tracking a number of We do not track tests disabled through |
Thank you for solving our concern! All the CI tests also pass. |
@intel/dpcpp-sanitizers-review All the CI tests have passed. Could you please help review this PR? Thank you! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
device sanitizer changes lgtm
@intel/llvm-gatekeepers please consider merging |
1 similar comment
@intel/llvm-gatekeepers please consider merging |
@YixingZhang007 , the following failed in post-commit:
Looks like you're on a public holiday today, so I'm reverting this. |
#20355) Reverts #20104 Post commit failed with ``` Failed Tests (6): SYCL :: Basic/image/image.cpp SYCL :: Basic/image/image_array.cpp SYCL :: Basic/image/srgba-read.cpp SYCL :: Regression/group_load_fortified.cpp SYCL :: bindless_images/array/read_write_unsampled_array.cpp SYCL :: bindless_images/read_write_unsampled.cpp ```
This PR re-enables SYCL end-to-end tests previously marked as XFAIL or UNSUPPORTED on the SPIR-V backend, as they now pass. For tests that are still failing, new issues have been created in llvm-project and added as XFAIL-TRACKER.