[SYCL] Update the kernel function pointer on function copy/move #20389
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slawekptak
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
slawekptak
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
slawekptak
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
The kernel function pointer, used to extract the kernel arguments, needs to point to the user provided function, or a function copy, if the copy/move is needed.
mmichel11
approved these changes
Oct 17, 2025
reble
approved these changes
Oct 17, 2025
There was a problem hiding this comment.
@mmichel11 We should also add your regression test, can do as a follow-up PR.
slawekptak
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
slawekptak
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
slawekptak
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
slawekptak
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
slawekptak
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
slawekptak
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
slawekptak
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
slawekptak
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
slawekptak
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
vinser52
approved these changes
Oct 20, 2025
|
@intel/llvm-gatekeepers please consider merging |
sarnex
pushed a commit
that referenced
this pull request
Oct 23, 2025
#20420) - Follow-up test case to the bug fixed in #20389 which was not caught by SYCL graph tests. - Exercises graph recording over queue submissions with handlerless APIs. Queue submissions are recorded over a non-inlined function call to provide coverage over now resolved kernel argument capture issues.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The kernel function pointer, used to extract the kernel arguments, needs to point to the user provided function, or a function copy, if the copy/move is needed.