-
Notifications
You must be signed in to change notification settings - Fork 791
[E2E][sycl-rel 6.3] Make lit search tools in bin/
directory
#20395
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
f580da6
to
9ef13c8
Compare
PATH
when building E2E testsbin/
directory
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but why there is no pre-commit run?
Weird. IDK. @AlexeySachkov Do you know what could be going wrong? |
This looks suspicious. I wonder if re-opening the PR would help. Worst case scenario re-creating it directly to I don't have fundamental objections against the change, but I would like to see the pre-commit run to confirm that it isn't accidentally broken by this patch (and that the issue with the test is actually resolved) |
Thanks, re-opening helped. |
IIUC, it won't be tested here. Instead, we'd need to merge, re-build the image with the sycl-rel-6.3 pre-compiled E2E binaries and only then have a passing pre-commit job in trunk. @uditagarwal97 can correct me if I'm wrong. |
@aelovikov-intel I think we should be able to verify the fix using pre-commit. I have another PR targeted to sycl-rel 6.3 (#20390) where all pre-commit E2E jobs failed due to this test failure. Comparing the CI runs in this PR and that in #20390, this PR works as intended and the issue is resolved. |
Merging this PR to fix pre-commit - |
Fixes E2E test failure in
SeperateCompile/test.cpp
in sycl-rel 6.3 ABI testing(https://github.com/intel/llvm/actions/runs/18599730732/job/53035028308#step:27:2964)The test failure is because of lit using system-installed
sycl-post-link
instead of the newly built one. This PR forces lit to find and use tools from<compiler build>/bin
directory.These changes are already in
sycl
branch (brought in by #19669)