Skip to content

[SYCL RTC] Add one forgotten consumeError #20405

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: sycl
Choose a base branch
from
+9 −5
Open

[SYCL RTC] Add one forgotten consumeError #20405

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 9 additions & 5 deletions sycl-jit/jit-compiler/lib/rtc/DeviceCompilation.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -434,19 +434,20 @@ class SYCLToolchain {
return (void)UseCachedPreamble(PCHStorage);
};

auto CacheOrErr =
llvm::Expected<llvm::FileCache> CacheOrErr =
llvm::localCache("SYCL RTC Persistent Preambles", "syclrtc-tmp-",
PersistentPCHDir, CacheCallback);

assert(CacheOrErr && "Don't see any code path returning Error");
auto AddStreamOrErr = (*CacheOrErr)(0, EncodedHash, "");
llvm::Expected<llvm::AddStreamFn> AddStreamOrErr =
(*CacheOrErr)(0, EncodedHash, "");
if (!AddStreamOrErr) {
// Not a hit, but we won't be able to store the data in the cache, so
// no need to generate precompiled preamble.
consumeError(AddStreamOrErr.takeError());
return RunWithoutPCH();
}
auto &AddStream = *AddStreamOrErr;
llvm::AddStreamFn &AddStream = *AddStreamOrErr;
if (!AddStream) {
// UseCachedPreamble was called by the cache after successfully
// reading persistent auto-pch file.
Expand All @@ -467,9 +468,12 @@ class SYCLToolchain {
// Any errors updating the persistent preambles cache won't affect
// current compilation, so ignore any error below:

auto FileOrErr = AddStream(1, "");
if (!FileOrErr)
llvm::Expected<std::unique_ptr<llvm::CachedFileStream>> FileOrErr =
AddStream(1, "");
if (!FileOrErr) {
consumeError(FileOrErr.takeError());
return Success;
}

llvm::CachedFileStream *CFS = FileOrErr->get();
raw_pwrite_stream &OS = *CFS->OS;
Expand Down