[SYCLLowerIR][GlobalOffset] Fix collection order of load's defs #20428
+184
−24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR fixes two issues in previous logic: * phi user of @llvm.amdgcn.implicit.offset call is not handled. * post-order collecting load's defs is wrong, producing wrong order in `PtrUses`.
wenju-he
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
wenju-he
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
wenju-he
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
wenju-he
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
wenju-he
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
wenju-he
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
wenju-he
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
wenju-he
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
YuriPlyakhin
approved these changes
Oct 22, 2025
| @@ -0,0 +1,45 @@ | |||
| ; RUN: opt -bugpoint-enable-legacy-pm -globaloffset %s -S -o - | FileCheck %s | |||
|
|
|||
| ; Check that phi is correctly handled in load's defs collection. | |||
There was a problem hiding this comment.
nit:
would it make sense to add test, where result of load is used? What would happen with those uses?
There was a problem hiding this comment.
nit: would it make sense to add test, where result of load is used? What would happen with those uses?
done, updated the test to have detailed check, thanks
wenju-he
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
wenju-he
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
wenju-he
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
|
@intel/llvm-gatekeepers please merge, thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes two issues in previous logic:
PtrUses.