Skip to content

[SYCL] Select the proper dependency tracking struct for graphs #20451

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 24, 2025
Merged

[SYCL] Select the proper dependency tracking struct for graphs #20451

merged 1 commit into from
Oct 24, 2025

Conversation

@slawekptak
Copy link
Contributor

This change makes the handler-less path select the proper dependency tracking struct instance, depending on whether the queue is associated with a graph.

@slawekptak slawekptak requested a review from a team as a code owner October 24, 2025 08:36
@slawekptak slawekptak changed the title [SYCL] Select the proper dependency tracking for graphs [SYCL] Select the proper dependency tracking struct for graphs Oct 24, 2025
steffenlarsen
steffenlarsen approved these changes Oct 24, 2025
View reviewed changes
Copy link
Contributor

@steffenlarsen steffenlarsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good find! Thanks for addressing this so quickly. 🚀

@slawekptak
[SYCL] Select the proper dependency tracking for graphs
f8249fd 
This change makes the handler-less path select the proper
dependency tracking struct instance, depending on whether
the queue is associated with a graph.
@steffenlarsen steffenlarsen mentioned this pull request Oct 24, 2025
Merged
@mmichel11 mmichel11 mentioned this pull request Oct 24, 2025
Draft
mmichel11
mmichel11 approved these changes Oct 24, 2025
View reviewed changes
Copy link
Contributor

@mmichel11 mmichel11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM!

I tried these changes out and confirmed it resolves the regression in #20448, so we do have a graph unit test with coverage of this issue.

@mmichel11 mmichel11 mentioned this pull request Oct 24, 2025
Closed
@sarnex
Copy link
Contributor

sarnex commented Oct 24, 2025

Merging now to fix CI

@sarnex sarnex merged commit 220a474 into intel:sycl Oct 24, 2025
49 of 53 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@steffenlarsen steffenlarsen steffenlarsen approved these changes

@mmichel11 mmichel11 mmichel11 approved these changes

@uditagarwal97 uditagarwal97 Awaiting requested review from uditagarwal97 uditagarwal97 is a code owner automatically assigned from intel/llvm-reviewers-runtime

@sergey-semenov sergey-semenov Awaiting requested review from sergey-semenov

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@slawekptak @sarnex @steffenlarsen @mmichel11