[SYCL] Don't generate optional string metadata node for aliasing MD #20478
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It was added just for LLVM IR readability during inlining, encoding original function name. We don't translate it to SPIR-V anyway. Meanwhile, since SYCL function names can be quite big - appearence of the string MD slightly worsen compilation performance. Signed-off-by: Sidorov, Dmitry <dmitry.sidorov@intel.com>
MrSidims
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
MrSidims
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
maarquitos14
approved these changes
Oct 27, 2025
MrSidims
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
MrSidims
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
MrSidims
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
|
@intel/llvm-gatekeepers please consider merging |
|
@MrSidims, do you have a PR in llvm-project with these changes? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was added just for LLVM IR readability during inlining, encoding original function name. We don't translate it to SPIR-V anyway. Meanwhile, since SYCL function names can be quite big - appearence of the string MD slightly worsen compilation performance, especially during module split.