-
Notifications
You must be signed in to change notification settings - Fork 796
[SYCL] Clear usesAssert required by fallback assert #20571
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: jinge90 <ge.jin@intel.com>
|
Hi, @steffenlarsen Thanks very much. |
@jinge90 - Thank you for testing this out! I expect it to be fine. If everything goes green, please feel free to remove the metadata. 🚀 |
Signed-off-by: jinge90 <ge.jin@intel.com>
Done. |
|
Hi, @steffenlarsen |
Signed-off-by: jinge90 <ge.jin@intel.com>
|
Hi, @intel/dpcpp-tools-reviewers |
maarquitos14
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
|
@intel/llvm-gatekeepers please consider merging |
steffenlarsen
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
The 'usesAssert' seems to be used by fallback assert mechanism which has beem discarded, create this PR to trigger pre-ci to see if any problem pops up if we remove the code snippet.