Skip to content

[SYCL][E2E] Make discard_events_l0_inorder.cpp to UNSUPPORTED #20623

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 12, 2025
Merged

[SYCL][E2E] Make discard_events_l0_inorder.cpp to UNSUPPORTED #20623

merged 1 commit into from
Nov 12, 2025

Conversation

@sarnex
Copy link
Contributor

@sarnex sarnex commented Nov 12, 2025

Seeing sporadic fails, ex here.

@sarnex
[SYCL][E2E] Make discard_events_l0_inorder.cpp to UNSUPPORTED
6f92de0 
Signed-off-by: Nick Sarnie <nick.sarnie@intel.com>
@sarnex sarnex marked this pull request as ready for review November 12, 2025 17:57
@sarnex sarnex requested a review from a team as a code owner November 12, 2025 17:57
@sarnex sarnex requested a review from maarquitos14 November 12, 2025 17:57
maarquitos14
maarquitos14 approved these changes Nov 12, 2025
View reviewed changes
Copy link
Contributor

@maarquitos14 maarquitos14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just wondering if it's time to drop the test completely, since it's a deprecated feature, according to the path. @intel/llvm-reviewers-runtime any thoughts? Not blocking this PR, just igniting the discussion. It can be done in a follow-up, if need be.

@sarnex
Copy link
Contributor Author

sarnex commented Nov 12, 2025

Merging now just to solve some CI issues for people, happy to remove test if it's decided in follow up

@sarnex sarnex merged commit e9880ca into intel:sycl Nov 12, 2025
28 checks passed
@aelovikov-intel
Copy link
Contributor

aelovikov-intel commented Nov 12, 2025

LGTM, just wondering if it's time to drop the test completely, since it's a deprecated feature, according to the path. @intel/llvm-reviewers-runtime any thoughts? Not blocking this PR, just igniting the discussion. It can be done in a follow-up, if need be.

The deprecated feature is a "hint", so it shouldn't affect stability. The fact that it fails means we have a serious bug somewhere, so what needs to be done is

  • Investigate that
  • Remove deprecated property and move/rename the test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@maarquitos14 maarquitos14 maarquitos14 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@sarnex @aelovikov-intel @maarquitos14