-
Notifications
You must be signed in to change notification settings - Fork 796
[Bench] Add stats for benchmark executions in GHA summary #20638
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
03ef5c3 to
37f2ec5
Compare
|
example summaries:
|
37f2ec5 to
a08ee95
Compare
|
|
||
| # Generate GitHub summary | ||
| if options.produce_github_summary: | ||
| generate_github_summary(execution_stats, failures) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hm, I think it might be better to move this to its own file, like we do for generating markdown and html. Btw, can't we use the existing markdown for this? Even if we simplify it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now using 2 files.
As for markdown re-using - I was thinking of removing the markdown option in the next step - is it used anywhere these days...?
a08ee95 to
c125082
Compare
c125082 to
fec99d9
Compare
PatKamin
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
@intel/llvm-gatekeepers please consider merging |
No description provided.