[SYCL][E2E] Move AOT tests off Gen12 #20643
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sarnex
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
sarnex
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
sarnex
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
sarnex
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
Signed-off-by: Nick Sarnie <nick.sarnie@intel.com>
sarnex
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
sarnex
changed the title
Contributor
|
I'm not familiar with that really... Maybe @AlexeySachkov knows more? |
Signed-off-by: Nick Sarnie <nick.sarnie@intel.com>
YuriPlyakhin
approved these changes
Nov 17, 2025
Contributor
YuriPlyakhin
left a comment
YuriPlyakhin
left a comment
There was a problem hiding this comment.
LGTM, but I second that @AlexeySachkov should take a look, just in case.
AlexeySachkov
approved these changes
Nov 18, 2025
Contributor
AlexeySachkov
left a comment
AlexeySachkov
left a comment
There was a problem hiding this comment.
I don't think that any of modified tests are invalidated by this change.
I don't like that we are hardcoding some specific targets into our tests, but I do not have a good (or any, in fact) proposal to address this, especially considering that we now compile E2E tests once, but then run them on multiple different machines.
Contributor
Author
|
Thanks Alexey! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On Windows, the GPU driver split into two, one that only supports GPUs after Gen12, and only that only supports GPUs before Gen12.
So for AOT we can't compile for BMG and Gen12 using the same
oclocexecutable.Instead of having to add LIT infrastructure for two
oclocexecutables and installing two versions on all the runners, just use DG2 instead of Gen12 for AOT tests which is supported on the new driver.Please make sure this change doesn't invalidate the test, for example if there is some capability difference between Gen12 and DG2 being tested that I broke.