[NewOffloadModel] Update clang-linker-wrapper test with issue fixes #20697
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YixingZhang007
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
YixingZhang007
changed the title
YixingZhang007
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
YixingZhang007
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
YixingZhang007
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
mdtoguchi
reviewed
Nov 20, 2025
YixingZhang007
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
mdtoguchi
approved these changes
Nov 20, 2025
mdtoguchi
approved these changes
Nov 20, 2025
YixingZhang007
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
YixingZhang007
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
YixingZhang007
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
Contributor
Author
|
I do not think the current failure in CI is related to the changes made in this PR :) |
YuriPlyakhin
approved these changes
Nov 20, 2025
Contributor
Author
|
@intel/llvm-gatekeepers The PR has been approved, and I don't think the current CI failure is caused by changes made in this PR. Could you please help merge this PR? Thank you :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request resolves a typo introduced in a recent modification of
clang/test/Driver/clang-linker-wrapper.cpp. In addition, the test logic is improved by replacing the use ofCHK-NO-CMDS-AOT-GEN-NOTwithCHK-NO-CMDS-AOT-GENto verify the behavior where the device name should not be passed tosycl-post-linkwhenclang-linker-wrapperis called with the--gpu-tool-arg=-device archargument.The previous PR introduced the mistake is #20470