Skip to content

[UR] Replace the pKMemObj argument with bool callWithArgs #20699

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 20, 2025
Merged

[UR] Replace the pKMemObj argument with bool callWithArgs #20699

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions unified-runtime/source/adapters/level_zero/v2/command_list_manager.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -155,7 +155,7 @@ ur_result_t ur_command_list_manager::appendKernelLaunchLocked(
ur_kernel_handle_t hKernel, ze_kernel_handle_t hZeKernel, uint32_t workDim,
const size_t *pGlobalWorkOffset, const size_t *pGlobalWorkSize,
const size_t *pLocalWorkSize, wait_list_view &waitListView,
ur_event_handle_t phEvent, bool cooperative, std::vector<void *> *pKMemObj,
ur_event_handle_t phEvent, bool cooperative, bool callWithArgs,
void *pNext) {

ze_group_count_t zeThreadGroupDimensions{1, 1, 1};
Expand All @@ -170,7 +170,7 @@ ur_result_t ur_command_list_manager::appendKernelLaunchLocked(
hContext.get(), hDevice.get(), pGlobalWorkOffset, workDim, WG[0], WG[1],
WG[2], getZeCommandList(), waitListView));

if (pKMemObj) {
if (callWithArgs) {
// zeCommandListAppendLaunchKernelWithArguments
TRACK_SCOPE_LATENCY("ur_command_list_manager::"
"zeCommandListAppendLaunchKernelWithArguments");
Expand Down Expand Up @@ -1228,7 +1228,7 @@ ur_result_t ur_command_list_manager::appendKernelLaunchWithArgsExpNew(
return appendKernelLaunchLocked(
hKernel, hZeKernel, workDim, pGlobalWorkOffset, pGlobalWorkSize,
pLocalWorkSize, waitListView, phEvent, cooperativeKernelLaunchRequested,
&hKernel->kernelMemObj, pNext);
true /* callWithArgs */, pNext);
}

ur_result_t ur_command_list_manager::appendKernelLaunchWithArgsExp(
Expand Down
2 changes: 1 addition & 1 deletion unified-runtime/source/adapters/level_zero/v2/command_list_manager.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -280,7 +280,7 @@ struct ur_command_list_manager {
uint32_t workDim, const size_t *pGlobalWorkOffset,
const size_t *pGlobalWorkSize, const size_t *pLocalWorkSize,
wait_list_view &waitListView, ur_event_handle_t phEvent, bool cooperative,
std::vector<void *> *pKMemObj = nullptr, void *pNext = nullptr);
bool withArgs = false, void *pNext = nullptr);

ur_result_t appendKernelLaunchUnlocked(
ur_kernel_handle_t hKernel, uint32_t workDim,
Expand Down
Loading