-
Notifications
You must be signed in to change notification settings - Fork 800
[LTO] Extend CAS build workaround to LTO #20814
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Nick Sarnie <nick.sarnie@intel.com>
YuriPlyakhin
approved these changes
Dec 3, 2025
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but please update #20304 with the reference to this new patch, so we would revert this patch as well, when the original issue is resolved.
jsji
approved these changes
Dec 4, 2025
Contributor
Author
|
Thanks @YuriPlyakhin! I missed the GH issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Shared library build fails with the same error Jinsong saw and fixed in e676cb0 as part of the pulldown. This was missed because we don't run the nightly as part of the pulldown CI, and we only do a shared library build in the nightly.
Fix confirmed in https://github.com/intel/llvm/actions/runs/19906696122/job/57064646962
Closes: #20743