[SYCL][FPGA] Enable USM address spaces by default for the hardware #2379
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The extension is enabled for FPGA H/W, but not for FPGA emulator. With this patch the temporary option "fsycl-enable-usm-address-spaces" is removed. Signed-off-by: Dmitry Sidorov <dmitry.sidorov@intel.com>
Signed-off-by: Dmitry Sidorov <dmitry.sidorov@intel.com>
Contributor
|
Thanks Dmitry! |
mohammadfawaz
previously approved these changes
Aug 27, 2020
Signed-off-by: Dmitry Sidorov <dmitry.sidorov@intel.com>
AGindinson
reviewed
Aug 28, 2020
Signed-off-by: Dmitry Sidorov <dmitry.sidorov@intel.com>
mdtoguchi
reviewed
Aug 28, 2020
| if (A->getOption().matches(options::OPT_Xs_separate) || | ||
| A->getOption().matches(options::OPT_Xs)) { | ||
| StringRef ArgString(A->getValue()); | ||
| if (ArgString == "hardware" || ArgString == "simulator") |
Contributor
There was a problem hiding this comment.
Are there any -Xs<arg> values that could disable -spirv-ext=+all?
Contributor
Author
There was a problem hiding this comment.
No, if a user has already passes hardware or simulator, than we enable +all (unless the user has also passed emulator option, like -Xshardwareemulator, but is it possible?)
Contributor
There was a problem hiding this comment.
It is not possible to pass -Xshardwareemulator or any other combination.
This reverts commit 0673272.
AGindinson
reviewed
Aug 31, 2020
mohammadfawaz
approved these changes
Aug 31, 2020
Contributor
mohammadfawaz
left a comment
mohammadfawaz
left a comment
There was a problem hiding this comment.
LGTM. Thanks Dmitry!
Chenyang-L
pushed a commit
that referenced
this pull request
Feb 18, 2025
Fix command_buffer coverity issues
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The extension is enabled for FPGA H/W, but not for FPGA emulator.
With this patch the temporary option "fsycl-enable-usm-address-spaces"
is removed.
Signed-off-by: Dmitry Sidorov dmitry.sidorov@intel.com