[SYCL] minor spelling fix for pragma #3373
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Chris Perkins <chris.perkins@intel.com>
kbobrovs
approved these changes
Mar 17, 2021
Contributor
|
Duplicate of already merged #3358. |
iclsrc
pushed a commit
that referenced
this pull request
Oct 15, 2025
With new lifetime.start/end rules, which are:
"The argument is either a pointer to an alloca instruction or a poison
value."
it became obsolete on main branch. Note, no test is possible to add
on the main branch.
Moreover, it seem to be redundant overall, as IR like this was legal:
%0 = alloca ...
%1 = bitcast %0
call void @llvm.lifetime.start(..., %1)
%2 = bitcast %0
call void @llvm.lifetime.end(..., %2)
Further implecations, and why this patch will be backported on older
branches. Right now there is a possibility to have a round-trip
translation failed, when it goes from main to pre-opaque pointers
branches as a bitcast from alloca to i8* will be inserted before
lifetime.start call. Later, due to the current logic, this bitcast will
be reused for lifetime.end call. But, lifetime.end won't always
post-dominate
lifetime.start (in this case the object will be considered dead at
function return block), hence the bitcast won't dominate the
lifetime.stop call, invalidating the generated module.
Signed-off-by: Sidorov, Dmitry <dmitry.sidorov@intel.com>
---------
Signed-off-by: Sidorov, Dmitry <dmitry.sidorov@intel.com>
Original commit:
KhronosGroup/SPIRV-LLVM-Translator@8ff535506896489
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Encountered when testing building intel/llvm with clang libc++.
Signed-off-by: Chris Perkins chris.perkins@intel.com