[SYCL] Pooling of USM memory allocated for buffers. #3420
Conversation
smaslov-intel
left a comment
smaslov-intel
left a comment
There was a problem hiding this comment.
When I opened this PR again, it showed multiple pending comments (apparently I missed to submit them). Please make sure they are resolved/addressed and request re-review.
|
The CutOff set at 2GB is the maximum poolable size supported by this implementation. The default is 1MB and the cutoff can be changed using the env var. However, even with the env var the upper limit cannot be made bigger than CutOff. |
smaslov-intel
left a comment
smaslov-intel
left a comment
There was a problem hiding this comment.
Please address remaining comments
| static size_t MaxPoolableSize = 1; | ||
| static size_t Capacity = 4; | ||
| static size_t MaxPoolSize = 256; | ||
| static size_t CurPoolSize = 0; |
There was a problem hiding this comment.
Can these be moved inside SetLimits class for better encapsulation?
smaslov-intel
left a comment
smaslov-intel
left a comment
There was a problem hiding this comment.
just minor asks for more comments
|
/summary:run |
smaslov-intel
left a comment
smaslov-intel
left a comment
There was a problem hiding this comment.
LGTM, but please run pre-commit testing
|
@rdeodhar, this patch broke post-commit build - https://github.com/intel/llvm/runs/2397183440?check_suite_focus=true. Please, fix ASAP. |
Spec link: #20504 Original commit: KhronosGroup/SPIRV-LLVM-Translator@a3a5de742179b34
4 participants
This change extends USM memory pooling to allocations beyond 64KB and also uses pooling for buffer allocations.