[SYCL][FPGA][NFC] LSU builtin test and documentation update #3546
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
romanovvlad
reviewed
Apr 19, 2021
Contributor
romanovvlad
left a comment
romanovvlad
left a comment
There was a problem hiding this comment.
LGTM, but would like that @mlychkov takes a look as well.
romanovvlad
approved these changes
Apr 20, 2021
Contributor
Author
|
merged to get this change: #3578 and enable the checks to pass. |
bader
approved these changes
Apr 22, 2021
romanovvlad
approved these changes
Apr 26, 2021
Contributor
Author
|
@bader Anything pending for the merge? |
Contributor
|
@intel/dpcpp-specification-reviewers team should approve the spec. |
mkinsner
approved these changes
Apr 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updating documentation to reflect change to multi_ptr.
Updating test so it tests device, host ptrs as well as accessor method.